Use unique cluster alias as identifier rather than redundant eksID#817
Open
linki wants to merge 1 commit into
Open
Use unique cluster alias as identifier rather than redundant eksID#817linki wants to merge 1 commit into
linki wants to merge 1 commit into
Conversation
linki
added
the
minor
linki
changed the title
Contributor
|
👍 |
Contributor
|
LGTM, once we decommission |
Member
Author
|
It's a little to much change at the moment. I'll put it on hold. |
Signed-off-by: Martin Linkhorst <martin.linkhorst@zalando.de>
linki
force-pushed
the
alias-instead-of-eks-id
branch
from
4b99849 to
2a211c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
eksID()generates redundant and unreadable EKS cluster names, as well as other resources that are based on it.For example, a cluster with alias
playground-2will have an EKS resource namedaws--123456789012--eu-central-1--kube-1for which the ARN will become a long, unreadable and redundant:[Update] Since the merge of #818 the ARN will look like this:
This isn't too bad, but it's unclear which cluster "kube-1" is. One has to use the AWS account ID to figure that out. Subsequent clusters in the same account would likely use "kube-2", "kube-3" etc. which isn't really helpful.
With this change the cluster will show in the UI as
playground-2and will always be unique as long as we pick unique cluster aliases. The ARN will become more useful and correct: